insights tests: ignore chrome api errors #3760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
force-pushed
the
fix-insights
branch
6 times, most recently
from
5e7e4da to
99ee1a2
Compare
copy insights tests, add before each with uncaught, remove insightsLogin conditionals - except for login method No-Issue
himdel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change insights test from mostly symlinking non-insights versions to proper copies,
unwind logic around insights vs non-insights there,
and add (empty) exception handlers in insights tests.
This means we no longer notice API errors in insights mode tests,
but also that tests no longer stop working every time the insights platform adds a new API call we don't mock.