Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up react imports #3780

Merged
merged 1 commit into from
May 29, 2023
Merged

clean up react imports #3780

merged 1 commit into from
May 29, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented May 29, 2023

we can do import React from 'react', import React, { foobar } from 'react', import * as React from 'react', but not import * as React, { foobar } from 'react'

unifying on the first 2

perl -i -npe 's/import \* as React/import React/' src/**/*.*

@himdel himdel added the cleanup Dead code removal, etc label May 29, 2023
@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels May 29, 2023
@himdel himdel removed backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels May 29, 2023
we can do `import React from 'react'`, `import React, { foobar } from 'react'`, `import * as React from 'react'`, but not `import * as React, { foobar } from 'react'`

unifying on the first 2

    perl -i -npe 's/import \* as React/import React/' src/**/*.*

No-Issue
@himdel himdel merged commit 38da20f into ansible:master May 29, 2023
@himdel himdel deleted the cleanup-react branch May 29, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Dead code removal, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant