Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository sync - modal to set mirror, optimize #3786

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Repository sync - modal to set mirror, optimize #3786

merged 2 commits into from
Jun 2, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented May 30, 2023

Issue: AAH-2301

Add Repository sync modal, instead of directly syncing with { mirror:true }, we open a modal with { mirror: true, optimize: true } preset, and allow changing both.

20230530190946
20230530190954

@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels May 30, 2023
@himdel himdel removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label May 30, 2023
@himdel
Copy link
Collaborator Author

himdel commented May 30, 2023

Cc @newswangerd

@newswangerd newswangerd self-requested a review May 31, 2023 13:22
@himdel himdel merged commit 8de7832 into ansible:master Jun 2, 2023
@himdel himdel deleted the sync-modal branch June 2, 2023 00:00
@patchback
Copy link

patchback bot commented Jun 2, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/8de7832e269b225d87ff01c04d6872e7e078b097/pr-3786

Backported as #3806

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 2, 2023
@himdel @patchback
Repository sync - modal to set mirror, optimize (#3786)
8cbd555 
* Repository sync - modal to set mirror, optimize

Issue: AAH-2301

* tests using repo sync - confirm modal

(cherry picked from commit 8de7832)
@patchback patchback bot mentioned this pull request Jun 2, 2023
Merged
himdel added a commit that referenced this pull request Jun 2, 2023
@patchback @himdel
Repository sync - modal to set mirror, optimize (#3786) (#3806)
b0e0339 
* Repository sync - modal to set mirror, optimize

Issue: AAH-2301

* tests using repo sync - confirm modal

(cherry picked from commit 8de7832)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newswangerd newswangerd newswangerd approved these changes

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himdel @newswangerd