-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository list - add columns, filters #3787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s never synced Combine sync status and last sync into a single column. This should still show the last sync status and date. The date could be a popover. If no remote is set on the repository, this column should say something like "no remote". If a remote is set, but a sync has never been performed this should say something like "never synced". Issue: AAH-2271
Add a "Labels" column that includes the pipeline and hide from search label Add a "Private" column that indicates if the repo is private or not Issue: AAH-2271
… repositories filter present repository list and approvals filter, but called Status, changed to Pipeline
Issue: AAH-2340
add typeahead filter by Remote, with an extra None (remote=null) option Issue: AAH-2271
MilanPospisil
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #3862 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
* Repository list sync status - merge status and date, show no remote vs never synced Combine sync status and last sync into a single column. This should still show the last sync status and date. The date could be a popover. If no remote is set on the repository, this column should say something like "no remote". If a remote is set, but a sync has never been performed this should say something like "never synced". Issue: AAH-2271 * Repository list - add Labels, Private columns Add a "Labels" column that includes the pipeline and hide from search label Add a "Private" column that indicates if the repo is private or not Issue: AAH-2271 * CHANGES * Add a "Pipeline" filter that lets the user select approved or staging repositories filter present repository list and approvals filter, but called Status, changed to Pipeline * ListPage: clean inputText on search Issue: AAH-2340 * page: remove unused didMount, extraState * Repository list - filter by Remote (or None) add typeahead filter by Remote, with an extra None (remote=null) option Issue: AAH-2271 * filter fixup - clean both inputText and selectedFilter (cherry picked from commit 8c77c9d)
5 tasks
himdel
added a commit
that referenced
this pull request
Jun 14, 2023
* Repository list sync status - merge status and date, show no remote vs never synced Combine sync status and last sync into a single column. This should still show the last sync status and date. The date could be a popover. If no remote is set on the repository, this column should say something like "no remote". If a remote is set, but a sync has never been performed this should say something like "never synced". Issue: AAH-2271 * Repository list - add Labels, Private columns Add a "Labels" column that includes the pipeline and hide from search label Add a "Private" column that indicates if the repo is private or not Issue: AAH-2271 * CHANGES * Add a "Pipeline" filter that lets the user select approved or staging repositories filter present repository list and approvals filter, but called Status, changed to Pipeline * ListPage: clean inputText on search Issue: AAH-2340 * page: remove unused didMount, extraState * Repository list - filter by Remote (or None) add typeahead filter by Remote, with an extra None (remote=null) option Issue: AAH-2271 * filter fixup - clean both inputText and selectedFilter (cherry picked from commit 8c77c9d) Co-authored-by: Martin Hradil <mhradil@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backported-4.7
This PR has been backported to stable-4.7 (2.4)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2271, AAH-2340
Add a "Private" filter(if the API doesn't support this, you can skip it for now)