Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository list - add columns, filters #3787

Merged
merged 8 commits into from
Jun 14, 2023
Merged

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented May 30, 2023

Issue: AAH-2271, AAH-2340

  • Combine sync status and last sync into a single column. This should still show the last sync status and date. The date could be a popover. If no remote is set on the repository, this column should say something like "no remote". If a remote is set, but a sync has never been performed this should say something like "never synced".
before after
20230530220652 20230530220621
  • Add a "Labels" column that includes the pipeline and hide from search label
  • Add a "Private" column that indicates if the repo is private or not

20230530221522

20230612185713
20230612185732
20230612185748

@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels May 30, 2023
@himdel himdel removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label May 30, 2023
himdel added 6 commits June 12, 2023 17:36
…s never synced

Combine sync status and last sync into a single column. This should still show the last sync status and date. The date could be a popover. If no remote is set on the repository, this column should say something like "no remote". If a remote is set, but a sync has never been performed this should say something like "never synced".

Issue: AAH-2271
Add a "Labels" column that includes the pipeline and hide from search label
Add a "Private" column that indicates if the repo is private or not

Issue: AAH-2271
… repositories

filter present repository list and approvals filter, but called Status, changed to Pipeline
@himdel himdel marked this pull request as ready for review June 12, 2023 18:53
add typeahead filter by Remote, with an extra None (remote=null) option

Issue: AAH-2271
Copy link
Contributor

@MilanPospisil MilanPospisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@himdel himdel merged commit 8c77c9d into ansible:master Jun 14, 2023
@himdel himdel deleted the repo-list branch June 14, 2023 11:20
@patchback
Copy link

patchback bot commented Jun 14, 2023

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/8c77c9d5736c3031614672472aab5b183dc9da2f/pr-3787

Backported as #3862

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 14, 2023
* Repository list sync status - merge status and date, show no remote vs never synced

Combine sync status and last sync into a single column. This should still show the last sync status and date. The date could be a popover. If no remote is set on the repository, this column should say something like "no remote". If a remote is set, but a sync has never been performed this should say something like "never synced".

Issue: AAH-2271

* Repository list - add Labels, Private columns

Add a "Labels" column that includes the pipeline and hide from search label
Add a "Private" column that indicates if the repo is private or not

Issue: AAH-2271

* CHANGES

* Add a "Pipeline" filter that lets the user select approved or staging repositories

filter present repository list and approvals filter, but called Status, changed to Pipeline

* ListPage: clean inputText on search

Issue: AAH-2340

* page: remove unused didMount, extraState

* Repository list - filter by Remote (or None)

add typeahead filter by Remote, with an extra None (remote=null) option

Issue: AAH-2271

* filter fixup - clean both inputText and selectedFilter

(cherry picked from commit 8c77c9d)
himdel added a commit that referenced this pull request Jun 14, 2023
* Repository list sync status - merge status and date, show no remote vs never synced

Combine sync status and last sync into a single column. This should still show the last sync status and date. The date could be a popover. If no remote is set on the repository, this column should say something like "no remote". If a remote is set, but a sync has never been performed this should say something like "never synced".

Issue: AAH-2271

* Repository list - add Labels, Private columns

Add a "Labels" column that includes the pipeline and hide from search label
Add a "Private" column that indicates if the repo is private or not

Issue: AAH-2271

* CHANGES

* Add a "Pipeline" filter that lets the user select approved or staging repositories

filter present repository list and approvals filter, but called Status, changed to Pipeline

* ListPage: clean inputText on search

Issue: AAH-2340

* page: remove unused didMount, extraState

* Repository list - filter by Remote (or None)

add typeahead filter by Remote, with an extra None (remote=null) option

Issue: AAH-2271

* filter fixup - clean both inputText and selectedFilter

(cherry picked from commit 8c77c9d)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants