Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cypress tests for collection upload with multiple repositories #3860

Merged
merged 4 commits into from
Jun 13, 2023
Merged

cypress tests for collection upload with multiple repositories #3860

merged 4 commits into from
Jun 13, 2023

Conversation

MilanPospisil
Copy link
Contributor

@MilanPospisil MilanPospisil commented Jun 12, 2023 •
edited
Loading

@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Jun 12, 2023
@himdel himdel removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Jun 12, 2023
@MilanPospisil MilanPospisil changed the title Test upload to multiple repo cypress tests for collection upload with multiple repositories Jun 13, 2023
@MilanPospisil
Changes file
03b5680 
Issue: AAH-2251
@MilanPospisil MilanPospisil marked this pull request as ready for review June 13, 2023 09:11
himdel
himdel reviewed Jun 13, 2023
View reviewed changes
src/components/repo-selector/multiple-repo-selector.tsx Outdated
@@ -100,6 +100,12 @@ export const MultipleRepoSelector = (props: IProps) => {
);
}

useEffect(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't sound like something we can do in the approval modal

@MilanPospisil MilanPospisil merged commit e9cab1b into ansible:master Jun 13, 2023
@patchback
Copy link

patchback bot commented Jun 13, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/e9cab1b41f21209fec115ca11868a67a0b2851fa/pr-3860

Backported as #3861

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 13, 2023
@MilanPospisil @patchback
cypress tests for collection upload with multiple repositories (#3860)
141e911 
* WIP

* Test moved to approvals + select staging implicitly in modal selector

* Changes file
Issue: AAH-2251

* Remove staging implicit selected repo

(cherry picked from commit e9cab1b)
@patchback patchback bot mentioned this pull request Jun 13, 2023
Merged
himdel pushed a commit that referenced this pull request Jun 13, 2023
@patchback @MilanPospisil
cypress tests for collection upload with multiple repositories (#3860) (
6000f29 
#3861)

* WIP

* Test moved to approvals + select staging implicitly in modal selector

* Changes file
Issue: AAH-2251

* Remove staging implicit selected repo

(cherry picked from commit e9cab1b)

Co-authored-by: MilanPospisil <arkanus@seznam.cz>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilanPospisil @himdel