Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community - fix token page expiration notice when auth provider is github #3879

Merged
merged 1 commit into from
Jun 28, 2023
Merged

community - fix token page expiration notice when auth provider is github #3879

merged 1 commit into from
Jun 28, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Jun 21, 2023

allow for null token expiration,
but also don't treat github as SSO

Issue: AAH-2324

@himdel himdel requested a review from jctanner June 21, 2023 00:54
@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Jun 21, 2023
@himdel himdel removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Jun 21, 2023
@himdel
community - fix token page expiration notice when auth provider is gi…
0c664d2 
…thub

allow for null token expiration,
but also don't treat github as SSO

Issue: AAH-2324
@himdel himdel added the community comunity mode feature label Jun 21, 2023
@himdel himdel merged commit 1976e22 into ansible:master Jun 28, 2023
@himdel himdel deleted the aah2324 branch June 28, 2023 21:37
@patchback
Copy link

patchback bot commented Jun 28, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/1976e22e458d7e9ebbeb7c15513edabd191cd0bb/pr-3879

Backported as #3900

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 28, 2023
@himdel @patchback
community - fix token page expiration notice when auth provider is gi…
907f8c4 
…thub (#3879)

allow for null token expiration,
but also don't treat github as SSO

Issue: AAH-2324
(cherry picked from commit 1976e22)
@patchback patchback bot mentioned this pull request Jun 28, 2023
Merged
himdel added a commit that referenced this pull request Jun 28, 2023
@patchback @himdel
community - fix token page expiration notice when auth provider is gi…
dcd9b23 
…thub (#3879) (#3900)

allow for null token expiration,
but also don't treat github as SSO

Issue: AAH-2324
(cherry picked from commit 1976e22)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jctanner jctanner Awaiting requested review from jctanner

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) community comunity mode feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@himdel