Namespace detail: use is_highest consistently #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespace detail shows the number of collections .. until we call `updateParams` when adding a filter or doing pagination, then it switches to showing the numnber of collection versions. Merge the 3 list queries into one function that's called twice .. once with real filters to set `collections` and `filteredCount`, and once with `page: 1, page_size: 1` to get the total `unfilteredCount` of all collections (which we then compare with 0). Issue: AAH-2443
github-actions
bot
added
backport-4.6
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #3949 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
namespace detail shows the number of collections .. until we call `updateParams` when adding a filter or doing pagination, then it switches to showing the numnber of collection versions. Merge the 3 list queries into one function that's called twice .. once with real filters to set `collections` and `filteredCount`, and once with `page: 1, page_size: 1` to get the total `unfilteredCount` of all collections (which we then compare with 0). Issue: AAH-2443 (cherry picked from commit 77ab3df)
himdel
added a commit
that referenced
this pull request
Jul 3, 2023
namespace detail shows the number of collections .. until we call `updateParams` when adding a filter or doing pagination, then it switches to showing the numnber of collection versions. Merge the 3 list queries into one function that's called twice .. once with real filters to set `collections` and `filteredCount`, and once with `page: 1, page_size: 1` to get the total `unfilteredCount` of all collections (which we then compare with 0). Issue: AAH-2443 (cherry picked from commit 77ab3df) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namespace detail shows the number of collections .. until we call
updateParamswhen adding a filter or doing pagination, then it switches to showing the numnber of collection versions.Merge the 3 list queries into one function that's called twice .. once with real filters to set
collectionsandfilteredCount, and once withpage: 1, page_size: 1to get the totalunfilteredCountof all collections (which we then compare with 0).Issue: AAH-2443