Repository/Remote delete: wait for task before requery, redirect to list screen instead of 404 after delete on detail #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…direct to list use for remote & repository delete No-Issue
github-actions
bot
added
the
backport-4.7
|
Cc @nixocio |
nixocio
approved these changes
Jul 21, 2023
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #4017 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
…ist screen instead of 404 after delete on detail (#4012) * add actionContext.listQuery to allow actions to requery on list or redirect to list use for remote & repository delete No-Issue * Repository/Remote delete: waitForTask before reloading/redirecting to list * handleHttpError - handle new Error, string, not just request * repository test - move mode logic up for clarity * collection test: increase timeout for copy_or_move_and_sign (cherry picked from commit 584908b)
himdel
added a commit
that referenced
this pull request
Jul 21, 2023
…ist screen instead of 404 after delete on detail (#4012) (#4017) * add actionContext.listQuery to allow actions to requery on list or redirect to list use for remote & repository delete No-Issue * Repository/Remote delete: waitForTask before reloading/redirecting to list * handleHttpError - handle new Error, string, not just request * repository test - move mode logic up for clarity * collection test: increase timeout for copy_or_move_and_sign (cherry picked from commit 584908b) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both Ansible Repositories and Ansible Remotes,
before, on a list screen: delete triggers a pulp task and reloads the list - the list may update before the delete task finished
after: UI waits for pulp task to finish before reloading
before, on a detail screen: delete triggers a pulp task and reloads the detail - can either update before deletion or successfully 404
after: UI waits for pulp task to finish before redirecting to list screen