[stable-4.7] Better choice of distribution when multiple per repo (#4007) #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a repository has multiple distributions, UI will just use the first candidate that leads to `inbound-*` distros being used instead of, say, `published` change the logic to first search for distribution where the name matches the repo name (and is still associated with the right repo), and only then fall back to the first candidate, but sorted so it will be the oldest distribution Issue: AAH-2586 * add `repositoryBasePath(name, pulp_href?): Promise<string>`, replace `RepositoriesUtils.distributionByRepoName` * use repositoryBasePath instead of manual or findDistroBasePathByRepo * use helper in even more places * rm unused api methods * types cleanup, merge ansible repository and repository * merge Repositories into AnsibleRepositoryAPI * fix imports, lint. sort-exports, tests (cherry picked from commit 367295f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #4007 to 4.7 (AAH-2586)
when a repository has multiple distributions, UI will just use the first candidate that leads to
inbound-*distros being used instead of, say,publishedchange the logic to first search for distribution where the name matches the repo name (and is still associated with the right repo), and only then fall back to the first candidate, but sorted so it will be the oldest distribution
Issue: AAH-2586
repositoryBasePath(name, pulp_href?): Promise<string>, replaceRepositoriesUtils.distributionByRepoName(cherry picked from commit 367295f)