Import modal: better error for Invalid file format. #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're checking the mime-type before allowing collection upload, this mostly works, but in some cases (see AAP-15541), it can fail unexpectedly. This should make debugging that case easier, by including the detected type in the error message. No-Issue
github-actions
bot
added
the
backport-4.7
|
might be a good idea to make the message ignorable, as per https://developer.mozilla.org/en-US/docs/Web/API/File/type, we might not want to rely on the type detection too much... => |
This comment was marked as outdated.
This comment was marked as outdated.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Aug 31, 2023
* Import modal: better error for Invalid file format. we're checking the mime-type before allowing collection upload, this mostly works, but in some cases (see AAP-15541), it can fail unexpectedly. This should make debugging that case easier, by including the detected type in the error message. No-Issue * make filetype detection error skippable (cherry picked from commit 9d4df78)
himdel
added a commit
that referenced
this pull request
Aug 31, 2023
* Import modal: better error for Invalid file format. we're checking the mime-type before allowing collection upload, this mostly works, but in some cases (see AAP-15541), it can fail unexpectedly. This should make debugging that case easier, by including the detected type in the error message. No-Issue * make filetype detection error skippable (cherry picked from commit 9d4df78)
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're checking the mime-type before allowing collection upload, this mostly works, but in some cases (see AAP-15541), it can fail unexpectedly.
This should make debugging that case easier, by including the detected type in the error message: