Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Add collection" modal - disable "Select" button when no collections are selected #4193

Merged
merged 1 commit into from
Sep 5, 2023
Merged

"Add collection" modal - disable "Select" button when no collections are selected #4193

merged 1 commit into from
Sep 5, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Sep 4, 2023

In repository detail, collection versions tab, when adding a collection to a repo, and no collections are selected, the "Select" button is still enabled.

Disabling when no collections are selected :)

20230904115019

@github-actions github-actions bot added the backport-4.7 This PR should be backported to stable-4.7 (2.4) label Sep 4, 2023
@himdel himdel merged commit 047dc91 into ansible:master Sep 5, 2023
@himdel himdel deleted the collection-select-disable branch September 5, 2023 13:15
@patchback
Copy link

patchback bot commented Sep 5, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/047dc913507a4c9b2e63d135c3630cf9b8075804/pr-4193

Backported as #4194

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Sep 5, 2023
Merged
patchback bot pushed a commit that referenced this pull request Sep 5, 2023
@himdel @patchback
"Add collection" modal - disable "Select" button when no collections …
8c045ae 
…are selected (#4193)

No-Issue

(cherry picked from commit 047dc91)
himdel added a commit that referenced this pull request Sep 5, 2023
@patchback @himdel
"Add collection" modal - disable "Select" button when no collections …
7b658f7 
…are selected (#4193) (#4194)

No-Issue

(cherry picked from commit 047dc91)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixocio nixocio nixocio approved these changes

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himdel @nixocio