Change the landing page banner. #4197
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backport-4.7
No-Issue
himdel
reviewed
Sep 10, 2023
| src='https://www.ansible.com/hubfs/rh-2023-summit-ansiblefest-ansible-galaxy-site-200x200.png' | ||
| width='50%' | ||
| alt='Generative Ai, The Ansible way. Try Ansible Lightspeed with IBM watsonx Code Assistant' | ||
| src='/static/images/LightspeedGalaxyAd1.png' |
There was a problem hiding this comment.
The file won't make it to /static/ in the build unless it's imported somewhere..
Suggested change
| src='/static/images/LightspeedGalaxyAd1.png' | |
| src={LightspeedGalaxyAd1} |
with an import LightspeedGalaxyAd1 from 'src/../static/images/LightspeedGalaxyAd1.png'; on the top.
EDIT: nope
There was a problem hiding this comment.
... Unless you already have the files available there, in which case, LGTM 👍 :)
(sorry, confusion between /static/ on the server and static/ in the repo)
himdel
approved these changes
Sep 10, 2023
himdel
added
community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ansible/galaxy-deploy/pull/226 makes it possible to use
/statc/images/path from s3