RoleRatings, CollectionRatings - display scores on role list/detail and collection detail #4283
+203
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.7
himdel
added
community
himdel
force-pushed
the
ratings
branch
7 times, most recently
from
dacfdd1 to
4b8550c
Compare
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Sep 27, 2023
various changes that don't belong in ansible#4283 No-Issue
himdel
force-pushed
the
ratings
branch
2 times, most recently
from
41cda78 to
dead73b
Compare
himdel
added a commit
that referenced
this pull request
Sep 27, 2023
various changes that don't belong in #4283 No-Issue
himdel
force-pushed
the
ratings
branch
2 times, most recently
from
59055d4 to
466e250
Compare
…res/
so that fetch('/static/scores/collection.json') works the same as on beta-galaxy
…nd collection detail, when available Issue: AAH-2289 Issue: AAH-2652
rochacbruno
reviewed
Sep 27, 2023
Comment on lines
+3
to
+4
| const collectionRatings = require('../static/scores/collection.json'); | ||
| const roleRatings = require('../static/scores/role.json'); |
There was a problem hiding this comment.
So you are using only these 2 files? in the next update I can include only the 2?
There was a problem hiding this comment.
As long as they stay small enough, absolutely :)
Chrome reports the transferred size (gzipped) as 16.8 kB and 40.9 kB, so it's faster to download and cache the whole thing than do per-item requests.
rochacbruno
approved these changes
Sep 27, 2023
|
Thanks, yup, but this time it's a non-change:
(webpack-config also expected to fail since there's an actual webpack config change for dev mode) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAH-2289 & AAH-2652
When available, display rating scores on role list detail & collection detail screens.
Role list:
Ratings tooltip (on hover):
Ratings popover (on click):
Role detail header:
Collection list (item only, not card):
Collection detail header: