Ensure community users can delete their collections #4305
Merged
+59
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: AAH-2632
github-actions
bot
added
backport-4.7
bmclaughlin
removed
backport-4.7
Issue: AAH-2632
Issue: AAH-2632
himdel
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
LGTM overall 👍
(though I haven't tested this yet)
Maybe we don't need the ai_deny_index (=is community) logic, because this should work like this (hasPermission(...) || hasObjectPermission(......)) in all the modes? Unless I'm missing something community specific?
(Either way LGTM, we can add this for standalone in a second PR when there's less things to worry about :))
Except some of the test failures still look real...
EDIT:
Tested, seems to work :)
Issue: AAH-2632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community users do not have the model permission
ansible.delete_collection, instead we rely on community users having object permissions on their namespace to determine if they have permissions to delete collections.Issue: AAH-2632
Links
PR (merged) implementing this same change in the api:
ansible/galaxy_ng#1900