-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language switcher #4366
Language switcher #4366
Conversation
options:
|
I would use the original language names. The chance that someone figures out that this is the language selector and finds a language they understand is a lot higher if they can at least read the names of the languages they understand :) (Just think of the UI being in a language and script you do not know, and you cannot even recognize one single language name since they are all in an unknown script. For example look at https://www.wikidata.org/wiki/Q1860#sitelinks-wikipedia and see in how many of the languages you can recognize that the article is about the English language :) )
Using flag emojis is a huge antipattern. There are countries with multiple languages (Canada, Switzerland, ...), and as you mentioned there are languages that are used in multiple countries (English, French, Spanish, German, ...). You can find some concrete examples here: https://www.flagsarenotlanguages.com/blog/why-flags-do-not-represent-language/
That would work, but it looks a bit ugly ;-) What you can always do is add the ISO 639-1 code in brackets next to the language name (like |
Issue: AAH-2730
language - always docs - not on login screen user - logged in, not anonymous login - not logged in, or anonymous
Issue: AAH-2730; discord
This adds a language switcher to standalone navbar:
closed

opened, using browser default language

manualy switched

manually switched back

(reset to browser defaults leads back to second screenshot :))
(the
(current)
,(browser default)
andReset to browser defaults
strings would be translated once we have the right strings in the catalog)This uses the language-switching mechanism introduced in #3225, updating it to not pass ?lang to API calls.