logout: reload user info after logout, instead of assuming null #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the UI doesn't really know about the anonymous user, except from the API so.. logout would set user to null, going through the codepath that redirects to /login, which would go to github and log in again instead, reloading the info when in anonymous mode, the user gets set to the anonymous user, with no redirects Issue: AAH-2726
github-actions
bot
added
backport-4.7
himdel
added
community
Backport to stable-4.8: 💚 backport PR created✅ Backport PR branch: Backported as #4386 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
because the UI doesn't really know about the anonymous user, except from the API so.. logout would set user to null, going through the codepath that redirects to /login, which would go to github and log in again instead, reloading the info when in anonymous mode, the user gets set to the anonymous user, with no redirects Issue: AAH-2726 (cherry picked from commit ceba5a3)
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #4387 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
because the UI doesn't really know about the anonymous user, except from the API so.. logout would set user to null, going through the codepath that redirects to /login, which would go to github and log in again instead, reloading the info when in anonymous mode, the user gets set to the anonymous user, with no redirects Issue: AAH-2726 (cherry picked from commit ceba5a3)
himdel
added a commit
that referenced
this pull request
Oct 10, 2023
… (#4387) because the UI doesn't really know about the anonymous user, except from the API so.. logout would set user to null, going through the codepath that redirects to /login, which would go to github and log in again instead, reloading the info when in anonymous mode, the user gets set to the anonymous user, with no redirects Issue: AAH-2726 (cherry picked from commit ceba5a3) Co-authored-by: Martin Hradil <mhradil@redhat.com>
himdel
added a commit
that referenced
this pull request
Oct 10, 2023
… (#4386) because the UI doesn't really know about the anonymous user, except from the API so.. logout would set user to null, going through the codepath that redirects to /login, which would go to github and log in again instead, reloading the info when in anonymous mode, the user gets set to the anonymous user, with no redirects Issue: AAH-2726 (cherry picked from commit ceba5a3) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
backported-4.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2726
The UI doesn't really know about the community mode anonymous user, except from the API which pretends it's just another user.
But logout would still set UI user to null, going through the codepath that redirects to /login, which would go to github and log in again instead.
Reloading the user info instead of using null, in community mode, the user gets set to the anonymous user, with no redirects.