Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused cypress transitive dependency #4439

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 24, 2023

We depend on cypress in test/,
but this is a transitive dependency of frontend-components-config,
and we're currently stuck on an older version of fcc..
=> removing that copy of cypress.

We depend on cypress in test/,
but this is a transitive dependency of frontend-components-config,
and we're currently stuck on an older version of fcc,
removing.

No-Issue
@himdel
Copy link
Collaborator Author

himdel commented Oct 24, 2023

(check this has no effect on crc stage) .. ✔️

@himdel himdel added cleanup Dead code removal, etc backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) labels Oct 24, 2023
@himdel himdel merged commit 4007571 into ansible:master Oct 31, 2023
@himdel himdel deleted the remove-transitive-cypress branch October 31, 2023 00:22
@patchback

This comment was marked as outdated.

@patchback

This comment was marked as outdated.

@patchback

This comment was marked as outdated.

@patchback

This comment was marked as outdated.

@himdel himdel removed backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 31, 2023
@himdel
Copy link
Collaborator Author

himdel commented Oct 31, 2023

(backports not necessary, only master depends on frontend-components (as opposed to frontend-components-config))

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Nov 1, 2023
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Nov 1, 2023
himdel added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Dead code removal, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant