Import modal - respect display_repositories, hide selector when no choices #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.7
himdel
force-pushed
the
collection-upload
branch
from
0743e21 to
221acd9
Compare
|
|
jctanner
approved these changes
Oct 31, 2023
nixocio
reviewed
Oct 31, 2023
… are no choices No-Issue
himdel
force-pushed
the
collection-upload
branch
from
221acd9 to
f0b84e6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Backport to stable-4.8: 💚 backport PR created✅ Backport PR branch: Backported as #4464 🤖 @patchback |
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Oct 31, 2023
…oices (ansible#4458) * Import modal - respect display_repositories, hide selector when there are no choices No-Issue * tests (cherry picked from commit 9c8e101)
github-actions
bot
added
the
backported-4.8
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
display_repositoriesfeature flag is disabled, don't show the "Staging Repos"/"All Repos" radios, only allow staging.When there is only 1 candidate choice within the current list, don't show the whole list, only the preselected repo.
Thus...
display_repositories == false, staging count == 1:display_repositories == true, staging count == 1:display_repositories == false, staging count > 1:display_repositories == true, staging count > 1: