eslint - use no-restricted-imports to dedup patternfly wrappers #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.7
himdel
added
cleanup
himdel
force-pushed
the
eslint-disable-patternfly
branch
3 times, most recently
from
657517b to
2d30b83
Compare
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Nov 11, 2023
himdel
force-pushed
the
eslint-disable-patternfly
branch
from
2d30b83 to
588b00a
Compare
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Nov 11, 2023
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Nov 11, 2023
…have wrappers for No-Issue
the span makes the title too big, and is not needed here
himdel
force-pushed
the
eslint-disable-patternfly
branch
from
8b60d0d to
7a8cbda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4107, #4457
Precedes #4141
We have a bunch of components wrapping patternfly, make sure we're always importing the wrapper (except in that wrapper).
Also move non-wrappers outside of patternfly-wrappers/, to shared/.