Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-4.9] Drop @redhat-cloud-services/frontend-components-config #4618

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Nov 26, 2023

Related to #4617
4.6: #4621
4.7: #4620
4.8: #4619


Drop @redhat-cloud-services/frontend-components-config,
along with @redhat-cloud-services/frontend-components and @redhat-cloud-services/frontend-components-config-utilities only used on master.

f-c-c v5 dependencies are becoming stale, v6 seems to need fec.config.js etc,
we don't need this for the stable branches, can just use a static webpack config.

(Add dependencies previously provided transitively through f-c-c)


Changes:

dev:

  • publicPath set to / not apps/automation-hub - webpack can serve it anywhere, no need to use insights defaults
  • no historyApiFallback.rewrites
  • no magicHtml
  • no MiniCssExtractPlugin in dev

shared:

  • rule for mjs
  • no fallback, not using those libraries in UI
  • no test: 'js' for sourcemaps (don't ignore css)
  • cleanStaleWebpackAssets: true - not sure why we'd keep them
  • no process, Buffer defs
  • no CRC_APP_NAME global, unused

prod:

  • no devServer, only in dev
  • MiniCssExtractPlugin ignoreOrder: false

@himdel himdel changed the title [stable-4.9] Bump @redhat-cloud-services/frontend-components-config to 6.0.5 (#4617) [stable-4.9] Drop @redhat-cloud-services/frontend-components-config Nov 27, 2023

Verified

This commit was signed with the committer’s verified signature.
himdel Martin Hradil
add babel-loader since f-c-c 6 no longer depends on it,

No-Issue

Verified

This commit was signed with the committer’s verified signature.
himdel Martin Hradil
fcc 6 seems to insist on pf5 and apparently also fec.config.js

makes sense for master, but simplifying for stable branches
@himdel himdel marked this pull request as ready for review November 28, 2023 03:07

Verified

This commit was signed with the committer’s verified signature.
himdel Martin Hradil
@himdel himdel merged commit db7c925 into ansible:stable-4.9 Nov 28, 2023
@himdel himdel deleted the 49-fcc branch November 28, 2023 03:47
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Nov 29, 2023

Verified

This commit was signed with the committer’s verified signature.
himdel Martin Hradil
mostly updating master to reflect changes from ansible#4618,
all of these are dependencies we're using, but only depenending on transitively

No-Issue
himdel added a commit that referenced this pull request Nov 29, 2023

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
mostly updating master to reflect changes from #4618,
all of these are dependencies we're using, but only depenending on transitively

No-Issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant