[stable-4.9] Collection upload/deprecate - fix permission checks (#4015) #4664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Collection upload/deprecate - fix permission checks Issue: AAH-2439 Issue: AAH-2853 * CollectionHeader - move actions & permissions to CollectionDropdown * Search,NamespaceDetail - use CollectionDropdown * namespace detail respect namespace permissions * fix delete collectio/ns disabled message, use description * inline tryOpenDeleteModalWithConfirm * deleteFn in all 3 dropdowns * linter fix * namespace detail - use object permissions for upload,delete,edit * tests - constistent kebab-toggle click * cy.openHeaderKebab - and scroll to top first * Ratings: don't load scores outside community mode No-Issue * collection-kebab - switch to data-cy * scrollTo fix * aargh, is it a timing bug? * upload new version is no longer available without permissions * openHeaderKebab: add comment about the wait (cherry picked from commit d0ad573)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #4015
Issue: AAH-2439, AAH-2853
Fixes permission checks for collection upload/deprecate on collection list ,namespace detail & collection detail.
display_repositoriesansible.delete_collectionORgalaxy.change_namespacedisplay_repositoriesansible.delete_collectionORgalaxy.change_namespacegalaxy.change_namespacegalaxy.upload_to_namespacecan_create_signaturesAND NOTcan_upload_signaturesgalaxy.change_namespaceANDgalaxy.upload_to_namespace