add tooltip component #484
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
reviewed
May 25, 2021
| <Tooltip | ||
| content={ | ||
| <div> | ||
| {this.getDescription(latest_version.metadata.description)} |
There was a problem hiding this comment.
getDescription is the function that's truncating the contents ... so right now you get the same shortened description in both the tooltip and the card ... this one should just be latest_version.metadata.description without the method call.
(Also no need for the <div> once #472 gets merged, but it's not merged yet so we do need it for now.)
himdel
approved these changes
May 26, 2021
|
pr closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Zita && Martin :)
Here is a pr for issue:
https://issues.redhat.com/browse/AAH-554
Just adding a tooltip for the descriptions. I did not differentiate between those visibly overflowing and those not.
