Fix namespace create form test to be idempotent. #555
Merged
+3
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
I like it 👍
@himdel Once we can delete a namespace we'll refactor it so the test deletes what it creates.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Jun 29, 2021
comes from ansible#555, didn't run npm run prettier, updating
ZitaNemeckova
pushed a commit
that referenced
this pull request
Jun 30, 2021
comes from #555, didn't run npm run prettier, updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAH-616 added the
namespace_form.jstest file. The last test, which creates a namespace, only works the first time the test is run. It requires resetting the database before another successful run.I believe all tests should be idempotent.
This small change randomizes the name of the namespace created so the test can pass every time.