update-manifest: drop user token #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use an encrypted deploy key instead unlike the cloud deploy key (5d66b9c), this one uses gpg: # encrypt gpg --symmetric --cipher-algo AES256 .travis/deploy_manifest # decrypt gpg --quiet --batch --yes --decrypt --passphrase="$MANIFEST_PASSPHRASE" --output .travis/deploy_manifest .travis/deploy_manifest.gpg
newswangerd
pushed a commit
to ansible/galaxy_ng
that referenced
this pull request
Sep 30, 2021
…973) * ci workflow: fix update_manifest update_manifest is currently failing to run for 2 reasons: GITHUB_PULL_REQUEST is set to a PR number during the pull_request event, and nothing during the push event, the script expects `false` fixing by testing GITHUB_PULL_REQUEST for nonempty GITHUB_BRANCH is set to github.head_ref, only available during pull_request events, the script tests for "master" or "stable" fixing by updating GITHUB_BRANCH to use github.ref sans the refs/heads/ prefix and removed the unused vars, as well as github.event.after which doesn't seem documented for push builds * update_manifest: use deploy key instead of user token same as ansible/ansible-hub-ui#946 the gpg-encrypted key is added to the repo, encrypted by a passphrase added to secrets No-Issue * post-job-template.yml.j2 - update and rerun `plugin-template --github galaxy_ng`
patchback bot
pushed a commit
to ansible/galaxy_ng
that referenced
this pull request
Sep 30, 2021
…973) * ci workflow: fix update_manifest update_manifest is currently failing to run for 2 reasons: GITHUB_PULL_REQUEST is set to a PR number during the pull_request event, and nothing during the push event, the script expects `false` fixing by testing GITHUB_PULL_REQUEST for nonempty GITHUB_BRANCH is set to github.head_ref, only available during pull_request events, the script tests for "master" or "stable" fixing by updating GITHUB_BRANCH to use github.ref sans the refs/heads/ prefix and removed the unused vars, as well as github.event.after which doesn't seem documented for push builds * update_manifest: use deploy key instead of user token same as ansible/ansible-hub-ui#946 the gpg-encrypted key is added to the repo, encrypted by a passphrase added to secrets No-Issue * post-job-template.yml.j2 - update and rerun `plugin-template --github galaxy_ng` (cherry picked from commit 436ffc4)
newswangerd
added a commit
to ansible/galaxy_ng
that referenced
this pull request
Sep 30, 2021
…973) (#999) * ci workflow: fix update_manifest update_manifest is currently failing to run for 2 reasons: GITHUB_PULL_REQUEST is set to a PR number during the pull_request event, and nothing during the push event, the script expects `false` fixing by testing GITHUB_PULL_REQUEST for nonempty GITHUB_BRANCH is set to github.head_ref, only available during pull_request events, the script tests for "master" or "stable" fixing by updating GITHUB_BRANCH to use github.ref sans the refs/heads/ prefix and removed the unused vars, as well as github.event.after which doesn't seem documented for push builds * update_manifest: use deploy key instead of user token same as ansible/ansible-hub-ui#946 the gpg-encrypted key is added to the repo, encrypted by a passphrase added to secrets No-Issue * post-job-template.yml.j2 - update and rerun `plugin-template --github galaxy_ng` (cherry picked from commit 436ffc4) Co-authored-by: Martin Hradil <mhradil@redhat.com> Co-authored-by: David Newswanger <dnewswan@redhat.com>
ZitaNemeckova
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use an encrypted deploy key instead
unlike the cloud deploy key (5d66b9c), this one uses gpg: