Improve python distribution metadata #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Replace imperative and redundant `setup.py` with a modern and recommended declarative approach `pyproject.toml`. 2. Unified linting tools configuration and store it in `pyproject.toml` aling with the distribution metadata. 3. Fix project dependencies. In the old `setup.py` there was a typo in `extra_requires=` setup parameter, which leaded to optional dependencies not being included into the distribution metadata.
himdel
reviewed
Apr 22, 2024
|
Looks good to me, but deferring to @chr-stian .. not sure how this affects the galaxykit build & release process. |
Co-authored-by: Martin Hradil <mhradil@redhat.com>
chr-stian
approved these changes
Apr 29, 2024
|
Info: The changes here require pip 23+. If anyone sees pip install successfully failing to install galaxykit (it seems to install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pywith a modern and recommended declarative approachpyproject.toml.pyproject.tomlaling with the distribution metadata.setup.pythere was a typo inextra_requires=setup parameter, which leaded to optional dependencies not being included into the distribution metadata.