Add deprecation warning for the mol command
#3407
Merged
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeboro
suggested changes
Jan 21, 2022
src/molecule/__main__.py
Outdated
| @@ -21,5 +21,17 @@ | |||
|
|
|||
| from molecule.shell import main | |||
|
|
|||
|
|
|||
| def mol_deprecation_notice(): | |||
| print( | |||
There was a problem hiding this comment.
We should probably use the warnings module here since there is already support for deprecating things.
The `mol` command can be replaced with a shell alias for those users that need it. Output a deprecation warning when the `mol` command is run that informs the user that the command will be removed in a future release of Molecule.
mperry2
force-pushed
the
mol-dep-notice
branch
from
b84b793 to
611ceed
Compare
for more information, see https://pre-commit.ci
|
I've updated the commit to use the warnings module. I set the category to |
tadeboro
approved these changes
Feb 6, 2022
ssbarnea
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
molcommand can be replaced with a shell alias for those users that needit. Output a deprecation warning when the
molcommand is run that informs theuser that the command will be removed in a future release of Molecule.
Addresses issue #3406