Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unexpected input underlined border when hover #52959

Merged

Conversation

ustcfury
Copy link
Contributor

πŸ€” This is a ...

  • πŸ†• New feature
  • [βœ… ] 🐞 Bug fix
  • πŸ“ Site / documentation improvement
  • πŸ“½οΈ Demo improvement
  • πŸ’„ Component style improvement
  • πŸ€– TypeScript definition improvement
  • πŸ“¦ Bundle size optimization
  • ⚑️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • πŸ›  Refactoring
  • 🎨 Code style optimization
  • βœ… Test Case
  • πŸ”€ Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

πŸ”— Related Issues

to #52947

πŸ“ Change Log

εŽ»ι™€ Input 组仢开启 variant="underlined" ζ—Ά disabled ηŠΆζ€δΈ‹ hover ζ—Άε‡ΊηŽ°ηš„δΈŠθΎΉζ‘†γ€‚

Language Changelog
πŸ‡ΊπŸ‡Έ English Remove the top border that appears when hovering in disabled state when variant="underlined" is enabled on the Input component.
πŸ‡¨πŸ‡³ Chinese εŽ»ι™€ Input 组仢开启 variant="underlined" ζ—Ά disabled ηŠΆζ€δΈ‹ hover ζ—Άε‡ΊηŽ°ηš„δΈŠθΎΉζ‘†γ€‚

Copy link

stackblitz bot commented Feb 25, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 25, 2025

πŸ‘ Visual Regression Report for PR #52959 Passed βœ…

🎯 Target branch: master (2af20aa)
πŸ“– View Full Report β†—οΈŽ
πŸ“– Alternative Report β†—οΈŽ

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Preview is ready

Copy link

Walkthrough

This pull request addresses a bug in the Input component where an unexpected top border appears when hovering over a disabled input with variant="underlined". The fix involves setting the top border color to transparent to remove the unwanted border effect.

Changes

File Summary
components/input/style/variants.ts Adjusted border color settings for disabled and hover states to ensure the top border is transparent, preventing unwanted border appearance.

Copy link

pkg-pr-new bot commented Feb 25, 2025

Copy link

codecov bot commented Feb 25, 2025

Bundle Report

Changes will increase total bundle size by 6 bytes (0.0%) ⬆️. This is within the configured threshold βœ…

Detailed changes
Bundle name Size Change
antd.min-array-push 3.38MB 6 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js 3 bytes 1.84MB 0.0%
antd.min.js 3 bytes 1.54MB 0.0%

Files in antd-with-locales.min.js:

  • ./components/input/style/variants.ts β†’ Total Size: 10.85kB

Files in antd.min.js:

  • ./components/input/style/variants.ts β†’ Total Size: 10.85kB

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 100.00%. Comparing base (2af20aa) to head (8eca561).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #52959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          769       769           
  Lines        13864     13864           
  Branches      3633      3633           
=========================================
  Hits         13864     13864           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@afc163 afc163 merged commit 21a44eb into ant-design:master Feb 25, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants