fix: EdgeFilterLens在触发update时，options.r未赋值给this.r，导致配置未生效；fix: style option的ts类型应该使用CircleStyleProps #6976
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2025 22:47
fix: style option的ts类型应该使用CircleStyleProps
yvonneyx
reviewed
Apr 9, 2025
| import { CommonEvent } from '../../constants'; | ||
| import { Circle } from '../../elements'; | ||
| import { Circle, CircleStyleProps } from '../../elements'; |
There was a problem hiding this comment.
import { Circle, type CircleStyleProps } from '../../elements';
|
🎁 Bonus+10 |
yvonneyx
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.r未赋值给this.r，导致此配置未生效；此问题与之前修复的fisheye plugins的问题类似，我是在编写在线体验时发现：
styleoption的ts类型，应该使用Partial<CircleStyleProps>更合适；