This repository was archived by the owner on Feb 25, 2019. It is now read-only.
tweaks to get server talking to external Java (mitreid) and passport-openid clients #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-ietf-jose-json-web-key-37 Rather than return a JSON array of JWKs, return an object that has a “keys” attribute that is the JSON array
previously these values were being added to the URL so they appeared on the wire and in logs
e.g. avoid error when config.development.json doesn’t include any provider configs
…cs/openid-connect-core-1_0.html Also added some devDependencies needed to get “npm test” working, and fixed all 3 broken test cases
also replaced stale test checking for User.email being mandatory, which it no longer is
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small OIDC differences from one spec and one draft spec, as well as loosening config requirement on external providers being mandatory. Also fixed some data leakage from auth screen.