Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finder App Extension #292

Open
3 of 6 tasks
aonez opened this issue Sep 28, 2018 · 37 comments
Open
3 of 6 tasks

Finder App Extension #292

aonez opened this issue Sep 28, 2018 · 37 comments
Assignees
Milestone

Comments

@aonez
Copy link
Owner

aonez commented Sep 28, 2018

Suggested here #248 (comment) by @gingerbeardman.


Some doc:

@NewsGuyTor
Copy link

Thanks, really looking forward to this.

My preference would be a context menu with a sub-menu, like this:

Screenshot

While having the menu be completely customizable would be best, the most important for me is to have both an "Extract here" and an "Extract to 'nameofzip/'" option there.

@aonez
Copy link
Owner Author

aonez commented Apr 15, 2020

@NewsGuyTor note that the current 1.2.0 beta already has a simple menu:

Screen Shot 2020-04-15 at 10 45 55

It has some file access limitations though. I'll add more options like those you mentioned for sure.

@aonez
Copy link
Owner Author

aonez commented Apr 15, 2020

Forgot to mention it is limited to the Desktop, at the moment.

@NewsGuyTor
Copy link

NewsGuyTor commented Apr 15, 2020

Good progress, looking forward to using it when it's ready. This is one thing that has always annoyed me with macOS compared to Windows (that you can't simply right click and chose between extracting in the same folder and extracting in a subfolder), but thankfully that is getting fixed! :)

BTW, IMO the menu should just be named "Keka" instead of "Open with Keka". In my mind you don't really open files you compress.

@gingerbeardman
Copy link
Contributor

gingerbeardman commented Apr 15, 2020

Aside:

A new app that allows custom Context Menu in macOS.

Other apps:

(I'm still using ContextMenu for a number of reasons)

@aonez
Copy link
Owner Author

aonez commented Apr 16, 2020

FiScript https://github.com/Mortennn/FiScript

@gingerbeardman never tried this one but I'm a big fan of @Mortennn's Dozer app.

@gingerbeardman
Copy link
Contributor

Morten said it's inspired by ContextMenu, very similar. Not quite as fully featured as CM though

@L1cardo
Copy link

L1cardo commented Apr 22, 2020

@NewsGuyTor note that the current 1.2.0 beta already has a simple menu:

Screen Shot 2020-04-15 at 10 45 55

It has some file access limitations though. I'll add more options like those you mentioned for sure.

I installed the beta version, but i did not see any changes

@gingerbeardman
Copy link
Contributor

I installed the beta version, but i did not see any changes

You need to activate it

Screen shot 2020-04-22 at 13 49 00

@L1cardo
Copy link

L1cardo commented Apr 22, 2020

I installed the beta version, but i did not see any changes

You need to activate it

Screen shot 2020-04-22 at 13 49 00

I did activate the finder extension, but nothing appeared 😂

@aonez
Copy link
Owner Author

aonez commented Apr 22, 2020 via email

@L1cardo
Copy link

L1cardo commented Apr 22, 2020

You’ve checked on the Desktop?

On Wed, 22 Apr 2020 at 14:52, Licardo notifications@github.com wrote:

I installed the beta version, but i did not see any changes

You need to activate it

[image: Screen shot 2020-04-22 at 13 49 00]
https://user-images.githubusercontent.com/49612/79983761-1a5a9800-84a0-11ea-9c62-0677af9b12d5.png

I did activate the finder extension, but nothing appeared 😂


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#292 (comment), or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADVHI5X7OOVPFPQSDPDFXLRN3SAXANCNFSM4FXYB35Q
.

Neither a desktop folder nor a file worked

@gingerbeardman
Copy link
Contributor

gingerbeardman commented Apr 22, 2020

True, enough, I only just installed 1.20 and I do not see the menu after activating the extension.

@aonez
Copy link
Owner Author

aonez commented Apr 23, 2020

@L1cardo what macOS version? @gingerbeardman that on 10.15?

@aonez
Copy link
Owner Author

aonez commented Apr 23, 2020

Note that the extension was built with a minimum requirement of 10.14 (Mojave) by error. The next revision will be 10.10+.

@L1cardo
Copy link

L1cardo commented Apr 23, 2020

@L1cardo what macOS version? @gingerbeardman that on 10.15?

10.15.4 (19E287)

@aonez
Copy link
Owner Author

aonez commented Apr 23, 2020

That's odd... Can you check in the Console.app -> system.log if there's some log about com.aone.keka.KekaFinderIntegration

Screen Shot 2020-04-23 at 12 51 35

@L1cardo
Copy link

L1cardo commented Apr 23, 2020

@gingerbeardman
Copy link
Contributor

gingerbeardman commented Apr 23, 2020

I'm on Mojave 10.14.6 (18G4032)

Nothing in console system.log

@aonez
Copy link
Owner Author

aonez commented Apr 24, 2020

Can you try this Keka-findersync build? I've enabled all paths in this version. Note it will only work properly where Keka has file access (this will change in the future). Use this build only for this test purpose, it has some changes in the extraction/compression code that are only 99.99% tested.

Also note that if you have any other 1.2.0 build macOS might load that Finder extension. You can always look in the Activity Monitor what extension is loaded:

Screen Shot 2020-04-24 at 12 01 37

Restarting the Finder reloads the extension, if needed.

@L1cardo
Copy link

L1cardo commented Apr 24, 2020

Unfortunately , this build can not be opened.
I reinstalled keka, can not be opened either.

image

@aonez
Copy link
Owner Author

aonez commented Apr 24, 2020

@L1cardo maybe you need to restart macOS? I don't really know what's happening there.

@L1cardo
Copy link

L1cardo commented Apr 24, 2020

@L1cardo maybe you need to restart macOS? I don't really know what's happening there.

have tried that, nothing happend

@aonez
Copy link
Owner Author

aonez commented Apr 24, 2020

Any message in the Console.app, filtered by Keka? Select your Mac in the Devices section in the left menu.

@L1cardo
Copy link

L1cardo commented Apr 24, 2020

Any message in the Console.app, filtered by Keka? Select your Mac in the Devices section in the left menu.

Nothing, cause keka can not even be opened.

image

@aonez
Copy link
Owner Author

aonez commented Apr 24, 2020

I reinstalled keka, can not be opened either.

Not even the stable 1.1.26 version?

@L1cardo
Copy link

L1cardo commented Apr 24, 2020

I reinstalled keka, can not be opened either.

Not even the stable 1.1.26 version?

Previous 1.2.0 beta is fine except for finder extension. but the new build you sent me can not be opened

@aonez
Copy link
Owner Author

aonez commented Apr 24, 2020

@L1cardo
Copy link

L1cardo commented Apr 24, 2020

@L1cardo try this one:
https://github.com/aonez/Keka/releases/download/dev-test-builds/Keka-findersync.dmg.zip

This one is good

image

@aonez aonez modified the milestones: 1.2.0, 1.3.0 Jun 5, 2020
@aonez
Copy link
Owner Author

aonez commented Jun 10, 2020

Released in the latest dev build: v1.2.0-dev.3901

@gingerbeardman
Copy link
Contributor

Can we hide the icon?

@NewsGuyTor
Copy link

Really nice!

It would be cool if the options changed depending on wether an extractable file were right clicked or not. As mentioned above I would also prefer the menu to just be titled "Keka" instead of "Open with Keka".

@aonez
Copy link
Owner Author

aonez commented Jun 13, 2020

@gingerbeardman @NewsGuyTor next build has some configuration:

Screenshot 2020-06-13 at 15 02 57

options changed depending on wether an extractable file were right clicked or not

Thought on that and eventually just limited the option if a folder is clicked. Apart from the performance impact of checking the file signature, you may want to compress an already compressed file or try to extract a file that might have an unknown signature for Keka but may be extracted anyway.

aonez added a commit that referenced this issue Jul 21, 2020
@aonez
Copy link
Owner Author

aonez commented Jul 24, 2020

It seems  is changing the Finder Extensions menu item placement in Big Sur...

Beta 2:

Screenshot 2020-07-24 at 11 43 56

Beta 3:

Screenshot 2020-07-24 at 11 31 39

@beResonant
Copy link

+1 for the ability to leverage hdiutil's split image file capability. It's an option and a parameter (split size). This would give the tool parity with the other algorithms and potentially enable backup of files containing characters native to MacOS that aren't supported in cloud syncing services (e.g. OneDrive, doesn't support : | \ * in filenames)

@aonez
Copy link
Owner Author

aonez commented Mar 19, 2021

@beResonant where was that feedback destined? Surely not to this issue 😅

@beResonant
Copy link

My bad?! apologies! 😅

I didn't want to post a new issue if one for what I was thinking already existed. I searched for "split dmg" and saw something in the to-do list at the top that looked like what I thought was the capability to make multi-part .dmg files. Sorry!

Do you think what I wrote is a new "issue?" Do you have a place you prefer for feature requests?

THanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants