Skip to content

Commit

Permalink
Add roles to create_user test (#20773)
Browse files Browse the repository at this point in the history
Flask App Builder 3.4.3 made role and conf_password obligatory
when creating user:
dpgaspar/Flask-AppBuilder#1758

Our test for user creation did not have the role set (though the
UI used it and the cient also allows to set it).

This change adds the `roles` in our tests to enable upgrade
to FAB 3.4.3 for the CI (currently tests in main fail because of
the test failure)

(cherry picked from commit a1a32f7)
  • Loading branch information
potiuk committed Jan 22, 2022
1 parent 9c6e2d6 commit bcf18e5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/www/views/test_views_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ def test_create_user(app, admin_client, non_exist_username):
'last_name': 'fake_last_name',
'username': non_exist_username,
'email': 'fake_email@email.com',
'roles': [1],
'password': 'test',
'conf_password': 'test',
},
Expand Down

0 comments on commit bcf18e5

Please sign in to comment.