Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AzureDataLakeStorage to ADLS #18493

Merged
merged 3 commits into from
Sep 25, 2021
Merged

Rename AzureDataLakeStorage to ADLS #18493

merged 3 commits into from
Sep 25, 2021

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Sep 24, 2021

Followup of #18168


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@mik-laj
Copy link
Member

mik-laj commented Sep 24, 2021

Can you add a note in CHANGELOG.rst file?

@eladkal
Copy link
Contributor Author

eladkal commented Sep 24, 2021

Can you add a note in CHANGELOG.rst file?

@potiuk creates them automatically :)

@mik-laj
Copy link
Member

mik-laj commented Sep 24, 2021

@eladkal for provider packages, this file has two roles - changelog and update guide. @potiuk updates the changelog, but we keep the update guide manually.

We have a similar case in Airflow Core We have a changelog, but we also have a note in UPDATING.md (Updating Guide). https://github.com/apache/airflow/blob/main/UPDATING.md#changes-to-import-paths

@mik-laj
Copy link
Member

mik-laj commented Sep 24, 2021

We also have a similar guide for backport providers. https://pypi.org/project/apache-airflow-backport-providers-google/ But we also have a changelog separately.

@eladkal
Copy link
Contributor Author

eladkal commented Sep 24, 2021

@mik-laj yeah we used to have it there but it was removed in #13767

Do you want me to create an UPDATEING.md in Azure provider? (Similar to https://github.com/eladkal/airflow/blob/1d722d84ef3c1f5d2cee2f4be72320b47fc9640b/airflow/providers/amazon/aws/ADDITIONAL_INFO.md ) ?

@mik-laj
Copy link
Member

mik-laj commented Sep 24, 2021

@eladkal We should have all information in UPDATING.md. For example, see: google provider -
https://github.com/apache/airflow/blob/main/airflow/providers/google/CHANGELOG.rst In this file, we have descriptions for multiple versions. In most cases, we have the only changelog in sections: "Features"
, "Bug Fixes" section, but we have sometimes additional sections such as "Updated google-cloud-* libraries", "Change in AutoMLPredictOperator". I think we should add a new section that describes how to update DAG to use the latest operators.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 25, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal eladkal merged commit 97d6892 into apache:main Sep 25, 2021
@eladkal eladkal deleted the azure branch September 25, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants