Move away from legacy importlib.resources API #19091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
importlib.resources deprecated the top-level read_binary() and similar functions in favor of the new files() API. This is only available in Python 3.9 and later, so the importlib-resources backport has been bumped to be also installed on 3.7 and 3.8.
|
BTW the |
mik-laj
approved these changes
Oct 20, 2021
|
CC: @lwyszomi |
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
🎉 🎉 🎉 |
potiuk
approved these changes
Oct 20, 2021
|
Reopening to check if it works for all Python versions. |
uranusjr
force-pushed
the
importlib-resources-deprecation
branch
from
07afbfa to
b213021
Compare
|
A couple of jobs got killed but CI otherwise passing. Should be good to go. |
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
potiuk
pushed a commit
that referenced
this pull request
Dec 12, 2021
(cherry picked from commit ed40c4b)
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib.resourcesdeprecated the top-levelread_binary()and similar functions in favor of the newfiles()API. This is only available in Python 3.9 and later, so theimportlib-resourcesbackport has been bumped to be also installed on 3.7 and 3.8.This should fix the errors in the provider tests and make CI green again.