Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log link in gantt view #20121

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

jedcunningham
Copy link
Member

The link to the log in the gantt view modal was a broken link as the execution_date wasn't isoformatted.

Closes #19613

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Dec 7, 2021
@jedcunningham jedcunningham added this to the Airflow 2.2.3 milestone Dec 7, 2021
task_dict['execution_date'] = dttm
task_dict['execution_date'] = dttm.isoformat()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign I really hate this subtle T and space difference in Python’s datetime.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@jedcunningham jedcunningham merged commit f59decd into apache:main Dec 8, 2021
@jedcunningham jedcunningham deleted the gantt-log-link branch December 8, 2021 16:11
jedcunningham added a commit that referenced this pull request Dec 8, 2021
(cherry picked from commit f59decd)
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open task log from Gantt view
3 participants