-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20139 - organize aws step_function #20158
Conversation
c3daba7
to
fb428dc
Compare
fb428dc
to
29e0d7b
Compare
29e0d7b
to
6e994cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are also missing edits to the test files of the operators / sensors.
Sensor:
https://github.com/apache/airflow/blob/main/tests/providers/amazon/aws/sensors/test_step_function_execution.py
should also be renamed and fix imports.
also since the classes are small we can have both of them in a single test_step_function.py
and we can remove the two individual test files.
da91fde
to
7446c01
Compare
@bhavaniravi could you please address also the comments on test files? |
Yes on it. |
ba9128c
to
5255834
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Part of #20139
Move step_function_* operators and sensors to
step_function.py