Add support for Spark Connect to pyspark decorator #35665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Apache Spark 3.4 Spark Connect was introduced which allows remote connectivity to remote Spark CLuster using the DataFrame API.
bolkedebruin
force-pushed
the
spark_connect
branch
from
969d8c3 to
f144535
Compare
uranusjr
reviewed
Nov 16, 2023
eladkal
approved these changes
Nov 16, 2023
eladkal
reviewed
Nov 16, 2023
There was a problem hiding this comment.
In general we prefer to keep service classes in single file. For example: #20139
That makes developer life easier with discovering the avaliable classes
There was a problem hiding this comment.
I understand the pattern, but I do think it is outside of the scope of this PR as it doesn't belong 'naturally' with one of the others so it would require refactoring all of them.
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
|
Oh... Spark connection page now would contain 4 different connections 😢 For the reference: #28790 |
|
I think the connection scheme would need rework to prevent this. Like a flavor of a particular connection or a sub type. Jdbc / Connect / Submit are significantly different from each other. |
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Apache Spark 3.4 Spark Connect was introduced which allows remote connectivity to remote Spark CLuster using the DataFrame API.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.