-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PythonVirtualenvOperator not working with Airflow context #9394
Fix PythonVirtualenvOperator not working with Airflow context #9394
Conversation
441ed1a
to
0253d8d
Compare
0253d8d
to
04903ec
Compare
22533e8
to
3043290
Compare
cd92619
to
c3c644c
Compare
c3c644c
to
b4ee6f7
Compare
PTAL @turbaszek @maganaluis @ashb @Fokko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @feluelle
b4ee6f7
to
46bf566
Compare
Ready for another round @turbaszek @Fokko |
46bf566
to
fe43c31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maganaluis if you want to backport this fix to 1.10 branch let me know if I can help you with it. :) I changed the description so it won't automatically close your issue and PR, because you want to target 1.10.x directly, correct? |
- automatically add dill requirement if use_dill=True - add howto docs - refactor Co-authored-by: Luis Magana <maganaluis@users.noreply.github.com>
fe43c31
to
f91bf8f
Compare
@feluelle Thank you for adding this fix, not sure if this change will work in the 1.10 branch? We forked the repo into GitHub Enterprise and added the fix there, I'm good with closing the issue and PR. I have interest to move to Airflow 2.0 because the REST API so I'm looking forward to it. |
Primarly this PR fixes an issue with PythonVirtualenvOperator not working in conjunction with airflow context arg.
Relates to #8177
Relates to #8256
But it also has a QoL improvement. You don't need to manually pass
dill
as requirement anymore if you have setuse_dill
toTrue
. So it won't raise an Error if you forgot to add it.Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.
cc @maganaluis