-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Use System Provided Flatbuffers #45636
Comments
So the more I've looked at this I've started to question if its worth the effort. From what I can read, it is a hard requirement for flatbuffers that the compiler and runtime versions match exactly. The odds of that are pretty low, so maybe not worth all of the extra CMake work here? |
I thought this is one of blockers of Meson support. If so, I'll take a look at this. |
I think the easiest path to Meson support would be to upgrade the vendored flatbuffers that CMake uses to a version that also exists in Meson's WrapDB. I'll investigate that further |
OK. Could you open a separated issue for upgrading the vendored Flatbuffers? |
Makes sense - see #45694 |
Describe the enhancement requested
Right now the project strictly requires the vendored version of flatbuffers, and places static assertions on main that the version of flatbuffers being used is 23.5.26
Instead of forcing the use of the vendored copy, we could open the project up to detecting a system dependency first, only falling back to the vendored copy when none is detected.
The origin of this conversation stems from the setup of the Meson build system in #45596 (comment)
@kou
Component(s)
C++
The text was updated successfully, but these errors were encountered: