GH-33464: [R] Troubles with using augmented columns #39542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
thisisnic
commented
Jan 10, 2024
| @@ -302,6 +301,8 @@ std::shared_ptr<acero::ExecNode> ExecNode_Scan( | |||
| "make_struct", std::move(exprs), | |||
| compute::MakeStructOptions{cpp11::as_cpp<std::vector<std::string>>(field_names)}); | |||
|
|
|||
| options->dataset_schema = GetProjectedSchemaFromExpression(options->projection, dataset->schema()); | |||
There was a problem hiding this comment.
I don't think we can actually do this this way as this function is internal, but I think that we need to do something like what this does.
github-actions
bot
added
awaiting changes
|
Closing this as the changes that need making appear to be at in libarrow not the R package C++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes a bug whereby augmented columns couldn't be used in subsequent expressions
What changes are included in this PR?
Includes the augmented column in the schema for the ScanNode
Are these changes tested?
Yes
Are there any user-facing changes?
Yes