-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45758 [Python] Add AzureFileSystem documentation #45759
Conversation
@github-actions crossbow submit preview-docs |
|
|
@kou, can you poke the bot please to build the sample docs? This is mostly github copilot generated but it's not a bad starting point. |
@github-actions crossbow submit preview-docs |
Revision: 4f656a6 Submitted crossbow builds: ursacomputing/crossbow @ actions-6df96eacef
|
@kou linting errors are all set, first scan of the doc preview looks good to me. |
Hopefully this bumps the pyarrow results when you google/bing/duckduckgo: azure storage pyarrow. The initial results are incredibly slow from a performance perspective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I made a few small suggestions and noticed one thing I think we should change: In the docs preview, instances of AzureFileSystem aren't automatically links as they should be. I think we need to add AzureFileSystem to the list in https://github.com/apache/arrow/blob/main/docs/source/python/api/filesystems.rst. Can you do that and see if it's fixed?
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
@amoeba all set. I did notice SubTreeFileSystem in the new file you linked:
It doesn't seem to exist in the main content file. I left it because it's unrelated to my change, but I'm unsure if it will cause an issue. |
@github-actions crossbow submit preview-docs |
Revision: 13eae3e Submitted crossbow builds: ursacomputing/crossbow @ actions-8735425042
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 69682cd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Missing documentation on AzureFileSystem
What changes are included in this PR?
Added ArrowFileSystem documentation
Are these changes tested?
Not yet
Are there any user-facing changes?
Documentation