-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12251: [Rust] Add Ballista to CI #9979
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9979 +/- ##
==========================================
- Coverage 82.70% 78.83% -3.87%
==========================================
Files 257 285 +28
Lines 60486 63731 +3245
==========================================
+ Hits 50027 50245 +218
- Misses 10459 13486 +3027
Continue to review full report at Codecov.
|
The build fails due to:
Root cause is that cmake is not installed. @Dandandan What is your recommendation? Do we need to use custom builder images? |
This came up for another project, and they added support for building snmalloc-[rs/sys] without cmake:
Personally, I would prefer snmalloc to be built with cmake, as that is what we test the most. But, if that is not possible for your scenario, this option is there. |
Thanks @mjp41 I think that's a great option. |
I modified this PR to build without default features, just so we can enable CI quickly. I filed https://issues.apache.org/jira/browse/ARROW-12331 for the follow-up work for snmalloc. |
I confirmed that CI ran the build and tests for Ballista so will go ahead and merge this. |
Add `cargo build` and `cargo test` steps for Ballista. I will address fmt and clippy separately. Closes apache#9979 from andygrove/ballista-ci Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
Add `cargo build` and `cargo test` steps for Ballista. I will address fmt and clippy separately. Closes apache#9979 from andygrove/ballista-ci Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
Add `cargo build` and `cargo test` steps for Ballista. I will address fmt and clippy separately. Closes apache#9979 from andygrove/ballista-ci Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
Add
cargo build
andcargo test
steps for Ballista. I will address fmt and clippy separately.