Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback dill. #21898

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Rollback dill. #21898

merged 1 commit into from
Jun 16, 2022

Conversation

tvalentyn
Copy link
Contributor

Some tests failed internally with this upgrade and there is a risk that users may be broken. Let's roll back given that we are cutting a release today, out of caution.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@tvalentyn
Copy link
Contributor Author

R: @pabloem @ryanthompson591

@pabloem
Copy link
Member

pabloem commented Jun 15, 2022

Run Portable_Python PreCommit

@pabloem
Copy link
Member

pabloem commented Jun 15, 2022

Run PythonDocker PreCommit

@pabloem
Copy link
Member

pabloem commented Jun 15, 2022

Run Python_PVR_Flink PreCommit

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #21898 (4c6b6fb) into master (6bffe84) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21898      +/-   ##
==========================================
+ Coverage   74.01%   74.27%   +0.26%     
==========================================
  Files         699      701       +2     
  Lines       92675    93938    +1263     
==========================================
+ Hits        68589    69773    +1184     
- Misses      22831    22910      +79     
  Partials     1255     1255              
Flag Coverage Δ
python 83.84% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hon/apache_beam/runners/dataflow/internal/names.py 100.00% <100.00%> (ø)
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...examples/inference/sklearn_mnist_classification.py 47.50% <0.00%> (ø)
...m/examples/inference/pytorch_image_segmentation.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/runners/common.py 88.80% <0.00%> (+0.12%) ⬆️
sdks/python/apache_beam/coders/coders.py 88.34% <0.00%> (+0.12%) ⬆️
sdks/python/apache_beam/io/avroio.py 98.30% <0.00%> (+0.28%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.37%) ⬆️
sdks/python/apache_beam/io/filebasedsource.py 99.21% <0.00%> (+0.42%) ⬆️
sdks/python/apache_beam/io/textio.py 97.97% <0.00%> (+1.07%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bffe84...4c6b6fb. Read the comment docs.

@Abacn
Copy link
Contributor

Abacn commented Jun 15, 2022

Should CHANGES.md also need rollback the line that announces the upgrade?

@pabloem pabloem closed this Jun 15, 2022
@pabloem pabloem reopened this Jun 15, 2022
@pabloem
Copy link
Member

pabloem commented Jun 15, 2022

yes @Abacn we would need to make sure this is not passed in CHANGES.md - I will manually remove this from the release nmotes for now

@pabloem
Copy link
Member

pabloem commented Jun 15, 2022

Run Python PreCommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants