-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollback dill. #21898
Rollback dill. #21898
Conversation
Run Portable_Python PreCommit |
Run PythonDocker PreCommit |
Run Python_PVR_Flink PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #21898 +/- ##
==========================================
+ Coverage 74.01% 74.27% +0.26%
==========================================
Files 699 701 +2
Lines 92675 93938 +1263
==========================================
+ Hits 68589 69773 +1184
- Misses 22831 22910 +79
Partials 1255 1255
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Should CHANGES.md also need rollback the line that announces the upgrade? |
yes @Abacn we would need to make sure this is not passed in CHANGES.md - I will manually remove this from the release nmotes for now |
Run Python PreCommit |
Some tests failed internally with this upgrade and there is a risk that users may be broken. Let's roll back given that we are cutting a release today, out of caution.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.