Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Resource.class to load resources, rather than its class loader #353

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Use Resource.class to load resources, rather than its class loader #353

merged 1 commit into from
Dec 28, 2024

Conversation

msfroh
Copy link
Contributor

@msfroh msfroh commented Dec 27, 2024

This plays nicer with Java's module system, as the class is able to load files from within the current module, whereas the classloader may not necessarily be able to.

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

@msfroh
Use Resource.class to load resources, rather than its classloader
3308200 
This plays nicer with Java's module system, as the class is able to
load files from within the current module, whereas the classloader
may not necessarily be able to.
@garydgregory
Copy link
Member

https://issues.apache.org/jira/browse/CODEC-324

@garydgregory garydgregory merged commit 5978452 into apache:master Dec 28, 2024
9 checks passed
@garydgregory garydgregory changed the title Use Resource.class to load resources, rather than its classloader Use Resource.class to load resources, rather than its class loader Dec 28, 2024
garydgregory added a commit that referenced this pull request Dec 28, 2024
@garydgregory
[CODEC-324] Use Resource.class to load resources, rather than its cla…
8e744dd 
…ss loader #353
@garydgregory
Copy link
Member

TY @msfroh !

omosteven pushed a commit to omosteven/commons-codec-lab-work that referenced this pull request Jan 8, 2025
@msfroh
Use Resource.class to load resources, rather than its classloader (ap…
7335cca 
…ache#353)

This plays nicer with Java's module system, as the class is able to
load files from within the current module, whereas the classloader
may not necessarily be able to.
omosteven pushed a commit to omosteven/commons-codec-lab-work that referenced this pull request Jan 8, 2025
@garydgregory
[CODEC-324] Use Resource.class to load resources, rather than its cla…
cf3ae1c 
…ss loader apache#353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msfroh @garydgregory