-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bump target sdk & build tools for SDK 33 support #1538
Conversation
b188355
to
d8d9bcc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 21 21
Lines 1751 1751
=======================================
Hits 1263 1263
Misses 488 488 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@jcesarmobile It seems that build tools Or do you think it would be better to keep it as is or even lower the minimum to |
Probably |
Which one you recommend? -> 33.0.0 |
I don’t know, since it’s the minimum allowed maybe 33.0.0, but both 33.0.0 and 33.0.1 present bugs that were fixed in 33.0.2, so not sure if we should require 33.0.2 as minimum |
We generally discourage people from updating the build tools version unless absolutely necessary/know what they are doing so we probably should use the latest patch available, so that cordova by default will use the latest patch available (at the time of this PR) obviously. 33.0.1 resolves a compilation issue:
It probably doesn't affect the cordova base but could affect other native libraries or third-party plugins. 33.0.2 addresses what appears to be a minor issue:
Nonetheless, I think we should just use the latest patch available, so that on release we can cleanly write an update guide stating they must have Just my own opinion. |
no, they can't use an older version since this value is for the minimum version allowed and the code has a check that prevents from using older versions that the one we set there but I'm ok making the minimum the latest at the moment of the release |
d8d9bcc
to
248893e
Compare
Motivation and Context
Set latest Target SDK & Build Tools Version.
Description
Testing
n/a
Checklist