Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump java default targets to 11 #1784

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 13, 2025

Motivation and Context

Resolve build warnings about Java 8 being obsolete.

warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release

Description

  • Java Source Compatibility to 11
  • Java Target Compatibility to 11
  • Remove Java 8 prefixing logic
  • Refactor/Cleanup Kotlin jvmTarget logic

Testing

  • Create project
  • Build project
  • Open Android Studio and built project there also.
  • Confirmed warnings are removed
  • Confirmed sample application launched in emulator

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.50%. Comparing base (7544fdf) to head (2edab74).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1784   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files          23       23           
  Lines        1837     1837           
=======================================
  Hits         1332     1332           
  Misses        505      505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu merged commit d0b5986 into apache:master Mar 14, 2025
14 checks passed
@erisu erisu deleted the feat/bump-java-requirements branch March 14, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants