Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump gradle to 8.13 #1785

Merged
merged 1 commit into from
Mar 18, 2025
Merged

feat: bump gradle to 8.13 #1785

merged 1 commit into from
Mar 18, 2025

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 17, 2025

Platforms affected

n/a

Motivation and Context

Description

Update default version and test to 8.13

Testing

  • npm t
  • Build test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from breautek March 17, 2025 01:26
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.00%. Comparing base (7f95294) to head (99f7721).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1785   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files          23       23           
  Lines        1850     1850           
=======================================
  Hits         1332     1332           
  Misses        518      518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu requested a review from dpogue March 17, 2025 02:32
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but I'm not up to speed on Gradle versions and AGP requirements, so appreciate if someone more familiar with the Android side of things can also take a look

@erisu erisu force-pushed the feat/bump-gradle branch from fdfff9b to 99f7721 Compare March 17, 2025 03:37
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle versions are pretty safe to update as long as you're not crossing major versions.

It's the AGP that can introduce breaking changes on any upgrade, as they don't practice semver, but another versioning scheme.

AGP 8.9 which I believe is the current latest requires minimum gradle 8.9 so this changes looks good to me.

@erisu erisu merged commit aad36fe into apache:master Mar 18, 2025
14 checks passed
@erisu erisu deleted the feat/bump-gradle branch March 18, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants