Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CordovaResourceApi.java #468

Closed
wants to merge 1 commit into from
Closed

Conversation

bikcrum
Copy link

@bikcrum bikcrum commented Jul 19, 2018

Add FileUtils class to support URI to getting real file path for different APIs.

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Add FileUtils class to support URI to getting real file path for different APIs.
@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files          17       17           
  Lines        1694     1694           
  Branches      312      312           
=======================================
  Hits         1026     1026           
  Misses        668      668

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e4598...ddffa06. Read the comment docs.

@janpio
Copy link
Member

janpio commented Jul 19, 2018

Hey @bikcrum, thanks for this PR.

What is the motivation for and use of this change?
Is there a JIRA issue that belongs to this code change?

@bikcrum
Copy link
Author

bikcrum commented Aug 13, 2018

@janpio I got some permission error while uploading media from Android API > 23. So I made changes to support for various Android APIs and it worked well.

@jcesarmobile
Copy link
Member

Looks pretty similar to current cordova-plugin-camera's FileHelper code
https://github.com/apache/cordova-plugin-camera/blob/master/src/android/FileHelper.java

@janpio janpio added the bug label Sep 18, 2018
@brody4hire
Copy link

Can we move some of this functionality into a plugin?

@brody4hire
Copy link

I think this needs investigation, adding the discussion label for now.

@lovelyelfpop
Copy link

lovelyelfpop commented Mar 2, 2021

Get real path of a content uri is not possible on Android Q+, CordovaResourceApi.java need refactoring

@erisu
Copy link
Member

erisu commented Jul 14, 2021

I am closing out this ticket. I believe that,

  • the request of this PR outdated
  • there is a lot of overlap with the cordova-plugin-camera. If there are any changes needed, add them to the camera plugin.
    • If the changes are not camera-specific, maybe start a discussion to migrate the class to the file plugin and make the file plugin a dependency of the camera?
  • there might be other changes needed since the PR creation to resolve major changes in the SDK 30 scope.

Additionally, there hasn't been any movement or discussion with the original author since 2018.

@erisu erisu closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants