Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js 12 to CI Services #724

Merged
merged 5 commits into from
Jul 14, 2019
Merged

Add Node.js 12 to CI Services #724

merged 5 commits into from
Jul 14, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented May 1, 2019

Platforms affected

none

Motivation and Context

Add Node 12 too CI

Description

  • Updated CI Service Config Files

Testing

none

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #724 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   66.57%   66.63%   +0.05%     
==========================================
  Files          18       18              
  Lines        1822     1822              
==========================================
+ Hits         1213     1214       +1     
+ Misses        609      608       -1
Impacted Files Coverage Δ
...n/templates/cordova/lib/builders/ProjectBuilder.js 70.23% <0%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf3dcf...075546a. Read the comment docs.

Remove once AppVeyor images support Node 12.
Copy link

@brody4hire brody4hire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this proposal should not be merged until we resolve the following:

More recent attempts to add Node.js 12 to CI are failing. I would like to look into this.

@brody4hire brody4hire merged commit a64d459 into apache:master Jul 14, 2019
@erisu erisu deleted the node12 branch July 14, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants