Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(travis): Fix Android SDK #765

Merged
merged 5 commits into from
Jul 11, 2019
Merged

ci(travis): Fix Android SDK #765

merged 5 commits into from
Jul 11, 2019

Conversation

janpio
Copy link
Member

@janpio janpio commented Jul 11, 2019 •
edited
Loading

CI is currently broken (noticed in #764), probably because Travis updated their images:

$ yes | sdkmanager tools > /dev/null
/home/travis/.travis/functions: line 104: sdkmanager: command not found
The command "yes | sdkmanager tools > /dev/null" failed and exited with 127 during .

We already updated the .travis.yml of paramedic to solve similar problems, so I used that as a template to get this one here working again as well. Restructed and reformatted the file along the way as well - but no functional changes.

@janpio janpio mentioned this pull request Jul 11, 2019
Merged
9 tasks
@janpio janpio changed the title ci(travis): Fix and add Node 12 ci(travis): Fix Android and add Node 12 Jul 11, 2019
@janpio janpio changed the title ci(travis): Fix Android and add Node 12 ci(travis): Fix Android SDK Jul 11, 2019
@janpio janpio marked this pull request as ready for review July 11, 2019 09:09
@janpio janpio requested review from raphinesse, dpogue, erisu and filmaj July 11, 2019 09:09
@janpio janpio added the bug label Jul 11, 2019
erisu
erisu approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@janpio janpio merged commit 906f8cc into master Jul 11, 2019
@janpio janpio deleted the janpio-fix_travis branch July 11, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

@raphinesse raphinesse Awaiting requested review from raphinesse

@dpogue dpogue Awaiting requested review from dpogue

@filmaj filmaj Awaiting requested review from filmaj

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janpio @erisu