Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove trailing spaces from app/build.gradle #990

Conversation

brody4hire
Copy link

(in the template)

Platforms affected

Android

Motivation and Context

Discovered while working on Gradle update in PR #988

Note that git grep -c ' $' shows trailing spaces in a number of other files. I discovered something similar in cordova-ios, would like to go through the other repos if I get a chance someday.

Description

remove trailing spaces from bin/templates/project/app/build.gradle

Testing

  • npm test
  • tested with cordova-sqlite-storage test app

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@brody4hire brody4hire requested review from erisu and breautek June 8, 2020 16:21
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #990 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          21       21           
  Lines        1866     1866           
=======================================
  Hits         1271     1271           
  Misses        595      595           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a61b75...a0ef02e. Read the comment docs.

@brody4hire brody4hire merged commit 287bfcb into apache:master Jun 8, 2020
@brody4hire brody4hire deleted the cleanup-remove-trailing-speces-from-app-build-gradle branch June 8, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants